netdev - Re: [net-next 1/6] e1000e: Avoid wrong check on TX hang

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20111203.222659.277419094309941060.davem@davemloft.net>
Date:	Sat, 03 Dec 2011 22:26:59 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	jeffrey.t.kirsher@...el.com
Cc:	wangyun@...ux.vnet.ibm.com, netdev@...r.kernel.org,
	gospo@...hat.com, sassmann@...hat.com, fbl@...hat.com
Subject: Re: [net-next 1/6] e1000e: Avoid wrong check on TX hang

From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Date: Sat,  3 Dec 2011 03:44:26 -0800

> +	if ((!adapter->tx_hang_recheck) &&

Excessive parenthesis, please remove.

> +		adapter->tx_hang_recheck = 1;

This variable is a bool, set it to true or false.

> +			adapter->tx_hang_recheck = 0;

Likewise.

> +	adapter->tx_hang_recheck = 0;

Likewise.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html