netdev - Re: [PATCH net-next 4/4 v2] bnx2x, cnic: support DRV

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1323158294.1762.4.camel@joe2Laptop>
Date:	Mon, 05 Dec 2011 23:58:14 -0800
From:	Joe Perches <joe@...ches.com>
To:	Michael Chan <mchan@...adcom.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org, barak@...adcom.com,
	eilong@...adcom.com
Subject: Re: [PATCH net-next 4/4 v2] bnx2x, cnic: support DRV_INFO upon FW
 request

On Mon, 2011-12-05 at 23:52 -0800, Michael Chan wrote:
> From: Barak Witkowski <barak@...adcom.com>
> Add support to send driver capabilities, settings and statistics to
> management firmware.
[]
> diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_hsi.h b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_hsi.h
[]
> @@ -1965,9 +1970,38 @@ struct shmem2_region {
[]
> +	u32 drv_capabilities_flag[E2_FUNC_MAX];
> +	#define DRV_FLAGS_CAPABALITIES_LOADED_SUPPORTED 0x00000001

capabilities.

> +	#define DRV_FLAGS_CAPABILITIES_LOADED_L2        0x00000002
> +	#define DRV_FLAGS_CAPABILITIES_LOADED_FCOE      0x00000004
> +	#define DRV_FLAGS_CAPABILITIES_LOADED_ISCSI     0x00000008

I think the #defines should be left aligned.

> +/*  Per PCI Function FCOE Statistics required from the driver */
> +struct fcoe_stats_info {
> +	u8 version[12];		/* Function's Driver Version. */
> +	u8 mac_local[8];	/* Locally Admin Addr. */
> +	u8 mac_add1[8];		/* Additional Programmed MAC Addr 1. */
> +	u8 mac_add2[8];		/* Additional Programmed MAC Addr 2. */

Should these addresses be u8 name[6]?


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html