netdev - Re: [PATCH net-next 4/4 v2] bnx2x, cnic: support DRV

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0E685F8B314BFB42AE2422915B7BDCC306626E@IRVEXCHMB07.corp.ad.broadcom.com>
Date:	Tue, 6 Dec 2011 08:12:06 +0000
From:	"Michael Chan" <mchan@...adcom.com>
To:	"'Joe Perches'" <joe@...ches.com>
cc:	"'davem@...emloft.net'" <davem@...emloft.net>,
	"'netdev@...r.kernel.org'" <netdev@...r.kernel.org>,
	"Barak Witkowski" <barak@...adcom.com>,
	"Eilon Greenstein" <eilong@...adcom.com>
Subject: Re: [PATCH net-next 4/4 v2] bnx2x, cnic: support DRV_INFO upon
 FW request

Joe Perches wrote:
> > +/*  Per PCI Function FCOE Statistics required from the driver */
> > +struct fcoe_stats_info {
> > +	u8 version[12];		/* Function's Driver Version. */
> > +	u8 mac_local[8];	/* Locally Admin Addr. */
> > +	u8 mac_add1[8];		/* Additional Programmed MAC Addr 1. */
> > +	u8 mac_add2[8];		/* Additional Programmed MAC Addr 2. */
> 
> Should these addresses be u8 name[6]?
> 
> 

I was told that this structure for management firmware was defined by
an OEM partner and they used 2 bytes of padding for these MAC addresses.