lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1323229439.2415.23.camel@jtkirshe-mobl>
Date:	Tue, 06 Dec 2011 19:43:59 -0800
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	Michael Wang <wangyun@...ux.vnet.ibm.com>
Cc:	"e1000-devel@...ts.sourceforge.net" 
	<e1000-devel@...ts.sourceforge.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"wangyunlinux@...il.com" <wangyunlinux@...il.com>,
	"Brandeburg, Jesse" <jesse.brandeburg@...el.com>
Subject: Re: [PATCH v2] e1000e: Assign true and false to bool type variable
 instead of 1 and 0

On Tue, 2011-12-06 at 18:33 -0800, Michael Wang wrote:
> From: Michael Wang <wangyun@...ux.vnet.ibm.com>
> 
> Use true and false instead of 1 and 0 when assign value to a bool type
> variable.
> 
> This patch is try to keep the style of driver, and according to
> David's
> suggestion on patch "e1000e: Avoid wrong check on TX hang":
> 
> http://marc.info/?l=linux-netdev&m=132296931201839&w=2
> 
> v2: add more description
> 
> Signed-off-by: Michael Wang <wangyun@...ux.vnet.ibm.com>
> ---
>  drivers/net/ethernet/intel/e1000e/netdev.c |   34
> ++++++++++++++--------------
>  1 files changed, 17 insertions(+), 17 deletions(-) 

Thanks Michael, I have added your patch to my queue of e1000e patches.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ