netdev - Re: [PATCH 00/10 net-next] Introduce per interface ipv4 statistics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 16 Dec 2011 16:41:20 +0100
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	igorm@....rs
Cc:	netdev@...r.kernel.org, davem@...emloft.net
Subject: Re: [PATCH 00/10 net-next] Introduce per interface ipv4 statistics

Le vendredi 16 décembre 2011 à 16:25 +0100, igorm@....rs a écrit :
> From: Igor Maravic <igorm@....rs>
> 
> Hi all,
> in this patch series I introduced per interface statistics for ipv4.
> 
> I referenced how it was done for ipv6 per interface statistics.
> BR
> Igor

Questions/Comments are :

1) Why is it needed ? Any RFC requires this bloat ?

2) Every patch in a patch serie must be compilable. Think about
bisection. This is mandatory.

  You cannot have a patch that change prototypes, like your 06/10 
-#define ICMP_INC_STATS(net, field)     SNMP_INC_STATS((net)->mib.icmp_statistics, field)
+#define ICMP_INC_STATS(net, dev, field)        \

 Then, in another patch, 'fix' callers, like your 10/10

-               IP_INC_STATS_BH(dev_net(dev), IPSTATS_MIB_INTRUNCATEDPKTS);
+               IP_INC_STATS_BH(dev_net(dev), dev, IPSTATS_MIB_INTRUNCATEDPKTS);



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html