netdev - Re: [PATCH 03/14] mac802154: RX data path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20111219.143608.1409188332664691009.davem@davemloft.net>
Date:	Mon, 19 Dec 2011 14:36:08 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	alex.bluesman.smirnov@...il.com
Cc:	dbaryshkov@...il.com, linux-zigbee-devel@...ts.sourceforge.net,
	netdev@...r.kernel.org
Subject: Re: [PATCH 03/14] mac802154: RX data path

From: Alexander Smirnov <alex.bluesman.smirnov@...il.com>
Date: Mon, 19 Dec 2011 19:33:43 +0300

> +void ieee802154_rx(struct ieee802154_dev *dev, struct sk_buff *skb, u8 lqi);
> +void ieee802154_rx_irqsafe(struct ieee802154_dev *dev, struct sk_buff *skb,
> +		u8 lqi);

Line up the "u8 lqi" argument with the openning parenthesis on the previous line.

> +static void
> +mac802154_subif_rx(struct ieee802154_dev *hw, struct sk_buff *skb, u8 lqi)
> +{
> +	struct mac802154_priv *priv = mac802154_to_priv(hw);
> +
> +	BUG_ON(!skb);

This assertion is excessive.

You are adding all of the call sites, therefore you can see if the SKB
argument is NULL or not.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html