netdev - Re: [PATCH 04/14] mac802154: TX data path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 19 Dec 2011 14:38:05 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	alex.bluesman.smirnov@...il.com
Cc:	dbaryshkov@...il.com, linux-zigbee-devel@...ts.sourceforge.net,
	netdev@...r.kernel.org
Subject: Re: [PATCH 04/14] mac802154: TX data path

From: Alexander Smirnov <alex.bluesman.smirnov@...il.com>
Date: Mon, 19 Dec 2011 19:33:44 +0300

> +netdev_tx_t mac802154_tx(struct mac802154_priv *priv, struct sk_buff *skb,
> +							u8 page, u8 chan);

Line up these arguments on the second line correctly!

If you can't do it properly by hand, use something like emacs's "C
mode" to do it for you automatically.

> +		res = xw->priv->ops->set_channel(&xw->priv->hw,
> +				xw->page,
> +				xw->chan);

Line up the arguments properly.

> +			pr_debug("(%s): set_channel failed\n", __func__);

Putting __func__ into the debugging printk's is excessive, take these out.

> +	if (WARN_ON(!(priv->phy->channels_supported[page] &
> +					(1 << chan))))

More poor formatting.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html