netdev - Re: [PATCH 10/14] ieee802154: interface type to be added

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20111219.144210.2223105215234869759.davem@davemloft.net>
Date:	Mon, 19 Dec 2011 14:42:10 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	alex.bluesman.smirnov@...il.com
Cc:	dbaryshkov@...il.com, linux-zigbee-devel@...ts.sourceforge.net,
	netdev@...r.kernel.org, alexander@...ovo
Subject: Re: [PATCH 10/14] ieee802154: interface type to be added

From: Alexander Smirnov <alex.bluesman.smirnov@...il.com>
Date: Mon, 19 Dec 2011 19:33:50 +0300

>  	int rc = -ENOBUFS;
>  	struct net_device *dev;
> +        int type = -EINVAL;

Bad indentation.

Or do you mean to tell me this doesn't look like total garbage and
stand out like a sore thumb on your computer screen?

> +		if (type > __IEEE802154_DEV_MAX) {
> +			return -EINVAL;
> +		}

No need for openning and closing braces here, there is simply one
statement in the basic block.

If you'll need them later, add them later, not now.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html