netdev - Re: [PATCH 11/14] mac802154: slaves manipulation routine

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20111219.144353.627184888133427434.davem@davemloft.net>
Date:	Mon, 19 Dec 2011 14:43:53 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	alex.bluesman.smirnov@...il.com
Cc:	dbaryshkov@...il.com, linux-zigbee-devel@...ts.sourceforge.net,
	netdev@...r.kernel.org, alexander@...ovo
Subject: Re: [PATCH 11/14] mac802154: slaves manipulation routine

From: Alexander Smirnov <alex.bluesman.smirnov@...il.com>
Date: Mon, 19 Dec 2011 19:33:51 +0300

> +struct ieee802154_dev *ieee802154_alloc_device(size_t priv_size,
> +					struct ieee802154_ops *ops);

Line up the arguments properly.

> +	if (priv->hw->open_count++ == 0) {
> +	res = priv->hw->ops->start(&priv->hw->hw);

That's terrible, fix up the indentation.

> +	if ((--priv->hw->open_count) == 0)

This is more canonical as "if (!--priv->hw->open_count)".
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html