lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 19 Dec 2011 17:08:39 -0800 From: Joe Perches <joe@...ches.com> To: David Miller <davem@...emloft.net> Cc: alex.bluesman.smirnov@...il.com, dbaryshkov@...il.com, linux-zigbee-devel@...ts.sourceforge.net, netdev@...r.kernel.org, alexander@...ovo.com Subject: Re: [PATCH 11/14] mac802154: slaves manipulation routine On Mon, 2011-12-19 at 14:43 -0500, David Miller wrote: > From: Alexander Smirnov <alex.bluesman.smirnov@...il.com> > > + if ((--priv->hw->open_count) == 0) > This is more canonical as "if (!--priv->hw->open_count)". Shrug. I think this is more readable and intelligible with the == 0. A test of a non-bool or non-ptr to a specific value seems reasonable to me. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists