netdev - Re: [PATCH 1/1] tcp: Replace constants with #define macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGK4HS-bWp4ju6LybJ7JeVbyTxH0Xg_g=Fh3PtwMsT4BUQkjEQ@mail.gmail.com>
Date:	Wed, 21 Dec 2011 11:43:45 -0800
From:	Vijay Subramanian <subramanian.vijay@...il.com>
To:	David Laight <David.Laight@...lab.com>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	eric.dumazet@...il.com, ilpo.jarvinen@...sinki.fi, hkchu@...gle.com
Subject: Re: [PATCH 1/1] tcp: Replace constants with #define macros

>
> Given the values are currently:
>
>> > +#define SACK_SEEN     (1 << 0)   /*1 = peer is SACK capable, */
>> > +#define FACK_ENABLED  (1 << 1)   /*1 = FACK is enabled locally*/
>> > +#define DSACK_SEEN    (1 << 2)   /*1 = DSACK was received from
> peer*/
>
> But the structure field member is 'sack_ok', unless it generates
> very silly long lines - which in this case it probably doesn't -
> it might even be worth prefixing with TCP_SACK_OK_ although
> that might be deemed excessive!
>

Thanks for all the feedback. I will follow these suggestions in future.

Vijay
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html