netdev - RE: [PATCH 1/1] tcp: Replace constants with #define macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AE90C24D6B3A694183C094C60CF0A2F6D8AF1E@saturn3.aculab.com>
Date:	Wed, 21 Dec 2011 09:57:41 -0000
From:	"David Laight" <David.Laight@...LAB.COM>
To:	"David Miller" <davem@...emloft.net>, <subramanian.vijay@...il.com>
Cc:	<netdev@...r.kernel.org>, <eric.dumazet@...il.com>,
	<ilpo.jarvinen@...sinki.fi>, <hkchu@...gle.com>
Subject: RE: [PATCH 1/1] tcp: Replace constants with #define macros

 
> > I assume you are talking about collision with userspace.  These
> > definitions are already protected by #ifdef  __KERNEL__.
> > That should be enough to protect against collisions with 
> userspace I think.
> 
> Within the kernel he means, please put a TCP_* prefix onto these
> values.

Given the values are currently:

> > +#define SACK_SEEN     (1 << 0)   /*1 = peer is SACK capable, */
> > +#define FACK_ENABLED  (1 << 1)   /*1 = FACK is enabled locally*/
> > +#define DSACK_SEEN    (1 << 2)   /*1 = DSACK was received from
peer*/

But the structure field member is 'sack_ok', unless it generates
very silly long lines - which in this case it probably doesn't -
it might even be worth prefixing with TCP_SACK_OK_ although
that might be deemed excessive!

	David


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html