netdev - Re: [PATCH] skge: restore multicast rx filter on resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111227095635.19087752@nehalam.linuxnetplumber.net>
Date:	Tue, 27 Dec 2011 09:56:35 -0800
From:	Stephen Hemminger <shemminger@...tta.com>
To:	David Miller <davem@...emloft.net>
Cc:	florz@...rz.de, netdev@...r.kernel.org
Subject: Re: [PATCH] skge: restore multicast rx filter on resume

On Mon, 26 Dec 2011 15:17:54 -0500 (EST)
David Miller <davem@...emloft.net> wrote:

> From: Florian Zumbiehl <florz@...rz.de>
> Date: Sun, 25 Dec 2011 09:18:33 +0100
> 
> > skge: restore multicast rx filter on resume
> >     
> > Signed-off-by: Florian Zumbiehl <florz@...rz.de>
> 
> Stephen?  This one looks fine to me.
> 
> > diff --git a/drivers/net/skge.c b/drivers/net/skge.c
> > index f4be5c7..cd968e5 100644
> > --- a/drivers/net/skge.c
> > +++ b/drivers/net/skge.c
> > @@ -4046,6 +4046,7 @@ static int skge_resume(struct device *dev)
> >  				dev_close(dev);
> >  				goto out;
> >  			}
> > +			skge_set_multicast(dev);
> >  		}
> >  	}
> >  out:

Right idea, but it needs to be done in a different spot to catch
all the other device restart cases like changing settings.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html