[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20111228074143.GA8041@florz.florz.dyndns.org>
Date: Wed, 28 Dec 2011 08:41:43 +0100
From: Florian Zumbiehl <florz@...rz.de>
To: Stephen Hemminger <shemminger@...tta.com>
Cc: David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH] skge: restore multicast rx filter on resume
Hi,
> > > diff --git a/drivers/net/skge.c b/drivers/net/skge.c
> > > index f4be5c7..cd968e5 100644
> > > --- a/drivers/net/skge.c
> > > +++ b/drivers/net/skge.c
> > > @@ -4046,6 +4046,7 @@ static int skge_resume(struct device *dev)
> > > dev_close(dev);
> > > goto out;
> > > }
> > > + skge_set_multicast(dev);
> > > }
> > > }
> > > out:
>
> Right idea, but it needs to be done in a different spot to catch
> all the other device restart cases like changing settings.
Roughly like this maybe? (Successfully tested with an MTU change ...)
Florian
---------------------------------------------------------------------------
skge: restore rx multicast filter on resume
Signed-off-by: Florian Zumbiehl <florz@...rz.de>
diff --git a/drivers/net/skge.c b/drivers/net/skge.c
index f4be5c7..8f985a8 100644
--- a/drivers/net/skge.c
+++ b/drivers/net/skge.c
@@ -2587,6 +2587,9 @@ static int skge_up(struct net_device *dev)
spin_unlock_irq(&hw->hw_lock);
napi_enable(&skge->napi);
+
+ skge_set_multicast(dev);
+
return 0;
free_rx_ring:
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists