netdev - Re: [PATCH 02/14 v2] mac802154: allocation of ieee802154 device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20111228.023145.2078199792492848729.davem@davemloft.net>
Date:	Wed, 28 Dec 2011 02:31:45 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	alex.bluesman.smirnov@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 02/14 v2] mac802154: allocation of ieee802154 device

From: Alexander Smirnov <alex.bluesman.smirnov@...il.com>
Date: Wed, 28 Dec 2011 10:19:23 +0300

> Dear David,
> 
> 2011/12/26 David Miller <davem@...emloft.net>:
>> From: Alexander Smirnov <alex.bluesman.smirnov@...il.com>
>> Date: Mon, 26 Dec 2011 20:04:07 +0300
>>
>>> +     /*
>>> +      * SoftMAC device is registered and running. One can add
>>> +      * subinterfaces.
>>> +      */
>>> +     unsigned running:1;
>>
>> I told you to change this to a 'bool' in my previous review of your changes.
>>
>> I'm pretty much going to stop reviewing right here, because I don't
>> want to waste my time only to find out that you've ignored other
>> review feedback I've already given to you.
>>
> 
> Regarding your comments to my previous post, none of them was omitted. I
> reworked code according to them and added extended comments in a patch
> explaining why I can't follow your hint. The issue with 'bool' you marked
> was in another patch (#14) which I already fixed.

My bad, I thought I had asked you do it here too.

Sorry about that.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html