netdev - Re: [PATCH 02/14 v2] mac802154: allocation of ieee802154 device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 5 Jan 2012 18:11:54 +0400
From:	Alexander Smirnov <alex.bluesman.smirnov@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 02/14 v2] mac802154: allocation of ieee802154 device

Hello David,

2011/12/28 David Miller <davem@...emloft.net>:
> From: Alexander Smirnov <alex.bluesman.smirnov@...il.com>
> Date: Wed, 28 Dec 2011 10:19:23 +0300
>
>> Dear David,
>>
>> 2011/12/26 David Miller <davem@...emloft.net>:
>>> From: Alexander Smirnov <alex.bluesman.smirnov@...il.com>
>>> Date: Mon, 26 Dec 2011 20:04:07 +0300
>>>
>>>> +     /*
>>>> +      * SoftMAC device is registered and running. One can add
>>>> +      * subinterfaces.
>>>> +      */
>>>> +     unsigned running:1;
>>>
>>> I told you to change this to a 'bool' in my previous review of your changes.
>>>
>>> I'm pretty much going to stop reviewing right here, because I don't
>>> want to waste my time only to find out that you've ignored other
>>> review feedback I've already given to you.
>>>
>>
>> Regarding your comments to my previous post, none of them was omitted. I
>> reworked code according to them and added extended comments in a patch
>> explaining why I can't follow your hint. The issue with 'bool' you marked
>> was in another patch (#14) which I already fixed.
>
> My bad, I thought I had asked you do it here too.
>
> Sorry about that.

Should I wait for the review of remaining patches or it would be
better to resubmit all the series with changes according to your new
comments?

With best regards,
Alexander
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html