netdev - Re: [PATCH 3/5] inet_diag: Extend the meminfo report

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20111228.140227.1047349775267791507.davem@davemloft.net>
Date:	Wed, 28 Dec 2011 14:02:27 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	xemul@...allels.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 3/5] inet_diag: Extend the meminfo report

From: Pavel Emelyanov <xemul@...allels.com>
Date: Wed, 28 Dec 2011 22:58:57 +0400

> On 12/28/2011 10:45 PM, David Miller wrote:
>> From: Pavel Emelyanov <xemul@...allels.com>
>> Date: Wed, 28 Dec 2011 17:38:40 +0400
>> 
>>> Add the backlog length and wmem and rmem buffers limits.
>>> With this the TCP memory info is full and can be analyzed.
>>>
>>> Few words about extending the existing structure. The nla engine stores lengths of
>>> fields and the nla parser will parse the new format successfully (checked on the ss
>>> tool). But new apps will have to take this field's length into account. Hopefully
>>> this is acceptable price for not introducing another ext bit and structure.
>>>
>>> Singed-off-by: Pavel Emelyanov <xemul@...allels.com>
>> 
>> I think you'll need to add a new extension, rather than create this incompatability.
>> 
> 
> OK, I will, but I seem to misunderstand the NLA's length value then. My impression is
> that it was introduced to make it possible to put the payload of different length,
> probably adding more stuff at the end.

It's to validate that the object inside the attribute has the expected length.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html