netdev - Re: [PATCH] genetlink: add auto module loading

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20111228.140315.1485215996445763095.davem@davemloft.net>
Date:	Wed, 28 Dec 2011 14:03:15 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	shemminger@...tta.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] genetlink: add auto module loading

From: Stephen Hemminger <shemminger@...tta.com>
Date: Wed, 28 Dec 2011 11:02:08 -0800

> On Wed, 28 Dec 2011 13:49:39 -0500 (EST)
> David Miller <davem@...emloft.net> wrote:
> 
>> From: Stephen Hemminger <shemminger@...tta.com>
>> Date: Wed, 28 Dec 2011 10:19:58 -0800
>> 
>> > When testing L2TP support, I discovered that the l2tp module is not autoloaded
>> > as are other netlink interfaces. There is because of lack of hook in genetlink to call
>> > request_module and load the module.
>> > 
>> > Signed-off-by: Stephen Hemminger <shemminger@...tta.com>
>> 
>> Applied, but for completeness we should probably also handle the "by ID" case right
>> above this code block too.
>> 
>> Could you please submit a patch for that?
>> 
>> Thanks.
> 
> There is no point really. All the existing drivers,
> use GENL_ID_GENERATE which generates the ID when they are loaded.
> Chicken and egg principle.

Ok, then I wonder why we support ID based lookups at all.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html