netdev - RE: [net-next 8/9] ixgbe: add interface to export thermal data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <F6FB0E698C9B3143BDF729DF22286646025656@ORSMSX102.amr.corp.intel.com>
Date:	Thu, 5 Jan 2012 17:53:33 +0000
From:	"Skidmore, Donald C" <donald.c.skidmore@...el.com>
To:	Michal Miroslaw <mirqus@...il.com>,
	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>
CC:	"davem@...emloft.net" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"gospo@...hat.com" <gospo@...hat.com>,
	"sassmann@...hat.com" <sassmann@...hat.com>,
	"Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@...el.com>
Subject: RE: [net-next 8/9] ixgbe: add interface to export thermal data

>-----Original Message-----
>From: Michał Mirosław [mailto:mirqus@...il.com]
>Sent: Friday, December 23, 2011 9:59 AM
>To: Kirsher, Jeffrey T
>Cc: davem@...emloft.net; Skidmore, Donald C; netdev@...r.kernel.org;
>gospo@...hat.com; sassmann@...hat.com; Waskiewicz Jr, Peter P
>Subject: Re: [net-next 8/9] ixgbe: add interface to export thermal data
>
>2011/12/23 Jeff Kirsher <jeffrey.t.kirsher@...el.com>:
>> From: Don Skidmore <donald.c.skidmore@...el.com>
>>
>> Some of our adapters have thermal data available, this patch exports
>this
>> data via a read-only sysfs interface.
>
>Just curious: can't this use the hwmon subsystem to be consistent with
>other system monitoring devices?
>
>Best Regards,
>Michał Mirosław

Sorry about the slow response, first vacation then I hadn't heard of hwmon and wanted to look into it a bit.  I can see why you mentioned it as it looks to be close to what I'm trying to do here.  However I don't think it quite matches.  I'll list my thoughts below:

- We are trying to export a large set of data that our customers are requesting.  The thermals were just the first patch and the other data items wouldn't really fit well in the hwmon (i.e. FW version, secondary MAC address).
- Didn't seem like we had much data to offer hwmon anyway just sensor temp, caution threshold, maxop threshold and location of sensor.  All the other data (which you haven't seen yet so couldn't have known :) wasn't related.
- The thermal data we do have is defined in our FW and could change (number of sensors) based on that FW.  I wasn't sure whether that would be an issue for hwmon.
- I went with sysfs based on a conversation with Peter Waskiewicz.  He mentioned that there was discussion on how to export generic data at netconf and sysfs was brought up as the best choice. 

Thanks for reviewing the patch and bring up this question. :)
-Don Skidmore <donald.c.skidmore@...el.com>




 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html