netdev - Re: [PATCH v2] drivers: net: Fix dependency for EEPROM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 05 Jan 2012 10:11:21 -0600
From:	Larry Finger <Larry.Finger@...inger.net>
To:	Fabio Estevam <festevam@...il.com>
CC:	netdev@...r.kernel.org, linux-wireless@...r.kernel.org,
	gwingerde@...il.com, linville@...driver.com, davem@...emloft.net,
	Fabio Estevam <fabio.estevam@...escale.com>
Subject: Re: [PATCH v2] drivers: net: Fix dependency for EEPROM_93CX6

On 01/05/2012 07:37 AM, Fabio Estevam wrote:
> Fix the following build warning:
>
> warning: (KS8851&&  AX88796_93CX6&&  RTL8180&&  RTL8187&&  ADM8211&&  RT2400PCI&&  RT2500PCI&&  RT61PCI&&  RT2800PCI&&  R8187SE) selects EEPROM_93CX6 which has unmet direct dependencies (MISC_DEVICES)
>
> Signed-off-by: Fabio Estevam<fabio.estevam@...escale.com>
> ---
> Changes since v1:
> - Place MISC_DEVICES dependency into the 'depends on' line

Is this the right way to fix this? Whenever I get this kind of build warning, I 
usually attribute it to a problem with my local configuration and fix my copy of 
.config, not modify the build system. With this change, it seems to me that a 
lot of devices will suddenly disappear from the build with little explanation. I 
don't feel confident enough to NACK the patch, but I would like an expert to 
comment.

I have noticed that the defconfigs for various architectures are split between 
turning MISC_DEVICES on or off.

Larry
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html