netdev - Re: brcm80211 breakage..

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F0E3B7E.8040005@lwfinger.net>
Date:	Wed, 11 Jan 2012 19:46:38 -0600
From:	Larry Finger <Larry.Finger@...inger.net>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
CC:	Arend van Spriel <arend@...adcom.com>,
	"John W. Linville" <linville@...driver.com>,
	Network Development <netdev@...r.kernel.org>,
	"Franky (Zhenhui) Lin" <frankyl@...adcom.com>,
	Rafał Miłecki <zajec5@...il.com>
Subject: Re: brcm80211 breakage..

On 01/11/2012 07:06 PM, Linus Torvalds wrote:
> On Wed, Jan 11, 2012 at 9:00 AM, Larry Finger<Larry.Finger@...inger.net>  wrote:
>> --- wireless-testing-new.orig/drivers/bcma/sprom.c
>> +++ wireless-testing-new/drivers/bcma/sprom.c
>> @@ -230,6 +230,7 @@ int bcma_sprom_get(struct bcma_bus *bus)
>>          * TODO: understand this condition and use it */
>>         offset = (bus->chipinfo.id == 0x4331) ? BCMA_CC_SPROM :
>>                 BCMA_CC_SPROM_PCIE6;
>> +       pr_debug("SPROM offset 0x%x\n", offset);
>>         bcma_sprom_read(bus, offset, sprom);
>>
>>         if (bus->chipinfo.id == 0x4331)
>
> So I did that - the offset is printed out as 0x0830
> (BCMA_CC_SPROM_PCIE6). And when I change the offset to 0x0800
> (BCMA_CC_SPROM), the complaint about SPROM version goes away.
>
> IOW, these messages no longer exist:
>
> [    0.815750] bcma: Unsupported SPROM revision: 255
> [    0.815804] bcma: No SPROM available
>
> but that doesn't actually make anything *work*. The brcms errors still
> remain the same.
>
> So the SPROM issue seems to be real, but irrelevant.
>
> I also noticed that the CONFIG_BRCMDBG onyl enables pr_debug(), but
> doesn't actually #define DEBUG, so pr_debug() gets compiled out
> anyway.
>
> I'll try with -DDEBUG in the brcm80211 subdirectory and see if I get
> more interesting output that way.

OK. The SPROM issue is not completely irrelevant as that has to be correct, but 
obviously not sufficient.

What is the PCI ID for your device?

Larry
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html