netdev - Re: [PATCH net 2/2] net: WARN if skb_checksum_help() is called on skb requiring segmentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120117.103239.724200729662879608.davem@davemloft.net>
Date:	Tue, 17 Jan 2012 10:32:39 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	herbert@...dor.hengli.com.au
Cc:	bhutchings@...arflare.com, netdev@...r.kernel.org
Subject: Re: [PATCH net 2/2] net: WARN if skb_checksum_help() is called on
 skb requiring segmentation

From: Herbert Xu <herbert@...dor.hengli.com.au>
Date: Tue, 17 Jan 2012 17:11:15 +1100

> On Mon, Jan 16, 2012 at 10:43:38PM +0000, Ben Hutchings wrote:
>> skb_checksum_help() has never done anything useful with skbs that
>> require segmentation.  Setting skb->ip_summed = CHECKSUM_NONE makes
>> them invalid and provokes a later WARNing in skb_gso_segment().
>> 
>> Passing such an skb to skb_checksum_help() indicates a bug, so we
>> should warn about it immediately.  Move the warning from
>> skb_gso_segment() into a shared function, and add the calling function
>> name, gso_type and gso_size to it.
>> 
>> Signed-off-by: Ben Hutchings <bhutchings@...arflare.com>
>> ---
>> The price for writing the warning format only once is having to pass in
>> the calling function name.  Not sure whether it's a good trade-off.
> 
> Do we really need the name since we should get a back trace?

Agreed.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html