netdev - Re: [PATCH v2] net: bpf_jit: fix divide by 0 generation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120118174807.GA5159@linuxace.com>
Date:	Wed, 18 Jan 2012 09:48:07 -0800
From:	Phil Oester <kernel@...uxace.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH v2] net: bpf_jit: fix divide by 0 generation

On Wed, Jan 18, 2012 at 06:21:42PM +0100, Eric Dumazet wrote:
> Several problems fixed in this patch :
> 
> 1) Target of the conditional jump in case a divide by 0 is performed
>    by a bpf is wrong.
> 
> 2) Must 'generate' the full function prologue/epilogue at pass=0,
>    or else we can stop too early in pass=1 if the proglen doesnt change.
>    (if the increase of prologue/epilogue equals decrease of all
>     instructions length because some jumps are converted to near jumps)
> 
> 3) Change the wrong length detection at the end of code generation to
>    issue a more explicit message, no need for a full stack trace.
> 
> Reported-by: Phil Oester <kernel@...uxace.com>
> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>
> ---
> Please Phil test following fix, thanks !

Looks good in testing so far, thank you!

Phil
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html