[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20120118.160442.2257803552295499142.davem@davemloft.net>
Date: Wed, 18 Jan 2012 16:04:42 -0500 (EST)
From: David Miller <davem@...emloft.net>
To: eric.dumazet@...il.com
Cc: kernel@...uxace.com, netdev@...r.kernel.org
Subject: Re: [PATCH v2] net: bpf_jit: fix divide by 0 generation
From: Eric Dumazet <eric.dumazet@...il.com>
Date: Wed, 18 Jan 2012 18:21:42 +0100
> Several problems fixed in this patch :
>
> 1) Target of the conditional jump in case a divide by 0 is performed
> by a bpf is wrong.
>
> 2) Must 'generate' the full function prologue/epilogue at pass=0,
> or else we can stop too early in pass=1 if the proglen doesnt change.
> (if the increase of prologue/epilogue equals decrease of all
> instructions length because some jumps are converted to near jumps)
>
> 3) Change the wrong length detection at the end of code generation to
> issue a more explicit message, no need for a full stack trace.
>
> Reported-by: Phil Oester <kernel@...uxace.com>
> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>
Applied and queued up for -stable, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists