netdev - ipt_LOG: No space after prefix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F1C0719.1010609@nod.at>
Date:	Sun, 22 Jan 2012 13:54:49 +0100
From:	Richard Weinberger <richard@....at>
To:	netfilter-devel@...r.kernel.org, netdev@...r.kernel.org
Subject: ipt_LOG: No space after prefix

Hi!

Is there no space after prefix for specific reason?
ipt_log_packet() is using this format string:
"<%d>%sIN=%s OUT=%s "

Using a prefix leads to a broken log entry like this one (prefix is "foo"):
"fooIN=eth0 OUT= ..."
I'm sure this breaks log analyzers.
I've never noticed this because I'm using prefix very seldom.

Thanks,
//richard

Download attachment "signature.asc" of type "application/pgp-signature" (491 bytes)