netdev - Re: ipt_LOG: No space after prefix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.01.1201221519200.10337@frira.zrqbmnf.qr>
Date:	Sun, 22 Jan 2012 15:20:32 +0100 (CET)
From:	Jan Engelhardt <jengelh@...ozas.de>
To:	Richard Weinberger <richard@....at>
cc:	netfilter-devel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: ipt_LOG: No space after prefix

On Sunday 2012-01-22 13:54, Richard Weinberger wrote:

>Hi!
>
>Is there no space after prefix for specific reason?
>ipt_log_packet() is using this format string:
>"<%d>%sIN=%s OUT=%s "
>
>Using a prefix leads to a broken log entry like this one (prefix is "foo"):
>"fooIN=eth0 OUT= ..."
>I'm sure this breaks log analyzers.

Changing it now will break log analyzers as well. So you are better off 
leaving it as-is, because everybody who has observed that before you 
already knows about it.
(Also consider --log-prefix "", in which case I would not want to have 
a space.)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html