netdev - Re: [PATCH 0/3] stmmac patches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120124.154311.1857537203481263793.davem@davemloft.net>
Date:	Tue, 24 Jan 2012 15:43:11 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	rubini@...dd.com
Cc:	linux-kernel@...r.kernel.org, peppe.cavallaro@...com,
	netdev@...r.kernel.org, giancarlo.asnaghi@...com
Subject: Re: [PATCH 0/3] stmmac patches

From: Alessandro Rubini <rubini@...dd.com>
Date: Tue, 24 Jan 2012 10:08:45 +0100

> The following three patches add support for the STA2X11 device in the
> stmmac driver. The device is a PCI-e bridge, so I need just to
> add my identifiers.  The identifiers being added are already in pci_ids
> of linux-next.

This patch is fine.

> The second patch is a cleanup, already acked by both authors.

I'm not applying this, instead if you want to make changes in this
area then fix this driver so that it can properly support multiple
device instances.

I can't even imagine ever writing a driver where from the start
it can handle only one device instance, this is pure insanity
especially for a PCI device driver.

> As for the third, I noted that there is "#ifndef MODULE" adding
> __setup directives, but the module parameters already work, and I
> successfully use stmmac.phy_id=1 to boot my system, so the __setup
> adre just duplicates. This has not been acked by Giuseppe Cavallaro
> but I offer it here nonetheless.

You're breaking things for anyone using 'stmmaceth='.  So I'm not
applying this patch either.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html