netdev - Re: [PATCH 0/3] stmmac patches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120124204710.GA29113@mail.gnudd.com>
Date:	Tue, 24 Jan 2012 21:47:10 +0100
From:	Alessandro Rubini <rubini@...dd.com>
To:	davem@...emloft.net
Cc:	linux-kernel@...r.kernel.org, peppe.cavallaro@...com,
	netdev@...r.kernel.org, giancarlo.asnaghi@...com
Subject: Re: [PATCH 0/3] stmmac patches

>> The second patch is a cleanup, already acked by both authors.
> 
> I'm not applying this, instead if you want to make changes in this
> area then fix this driver so that it can properly support multiple
> device instances.

Ok, I'll do, but not soon.
 
> I can't even imagine ever writing a driver where from the start
> it can handle only one device instance, this is pure insanity
> especially for a PCI device driver.

I agree. But it _already_ is like this. I just want the fact to be
clear, so when somebody burns two macs in the fpga it will complain
instead of breaking.   That said, I have no problem if you still
refuse it.

> You're breaking things for anyone using 'stmmaceth='.  So I'm not
> applying this patch either.

Fine with me.

thanks
/alessandro
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html