| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20120127223250.GA9384@gondor.apana.org.au> Date: Sat, 28 Jan 2012 09:32:50 +1100 From: Herbert Xu <herbert@...dor.apana.org.au> To: Alexey Dobriyan <adobriyan@...il.com> Cc: David Laight <David.Laight@...lab.com>, Linus Torvalds <torvalds@...ux-foundation.org>, linux-crypto@...r.kernel.org, netdev@...r.kernel.org, ken@...elabs.ch, Steffen Klassert <steffen.klassert@...unet.com>, security@...nel.org, Eric Dumazet <eric.dumazet@...il.com> Subject: Re: [PATCH 4/3] sha512: reduce stack usage even on i386 On Fri, Jan 27, 2012 at 08:51:30PM +0300, Alexey Dobriyan wrote: > > I think this is because your tree contained "%16" code instead if "&15". > Now that it contains "&15" it should become applicable. OK. > -------------------------------------------------------------------------- > [PATCH] sha512: reduce stack usage even on i386 Can you try the approach that git takes with using asm to read and write W (see previous email from Linus in respone to my push request)? As it stands your patch is simply relying on gcc's ability to optimise. At least with asm volatile we know that gcc will leave it alone. Thanks, -- Email: Herbert Xu <herbert@...dor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists