netdev - Re: [PATCH net-next 6/7] r8169: missing barriers.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120128120708.GA32677@electric-eye.fr.zoreil.com>
Date:	Sat, 28 Jan 2012 13:07:08 +0100
From:	Francois Romieu <romieu@...zoreil.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org,
	Hayes Wang <hayeswang@...ltek.com>
Subject: Re: [PATCH net-next 6/7] r8169: missing barriers.

Eric Dumazet <eric.dumazet@...il.com> :
[...]
> It would be good changelog explains the rationale, or you add comments
> in the code.

Something like :
----------------8<----------------------------------------------------------
rtl8169_tx_interrupt must see the updated queue status from
rtl8169_start_xmit while rtl8169_start_xmit still has to see the
updated dirty index from rtl8169_tx_interrupt.

The window for the TxPoll hack is widened: it should not make much
difference when the last TxPoll request in a close serie of xmit fails as
long as the Tx napi method runs late enough after the last successful xmit.
------------------------------------------>8--------------------------------

Your comments are welcome.

-- 
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html