netdev - Re: so many if conditions in _rtl92c_store_pwrIndex_diffrate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4F2425E1.7090407@lwfinger.net>
Date:	Sat, 28 Jan 2012 10:44:17 -0600
From:	Larry Finger <Larry.Finger@...inger.net>
To:	"devendra.aaru" <devendra.aaru@...il.com>
CC:	linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: so many if conditions in _rtl92c_store_pwrIndex_diffrate_offset.

On 01/28/2012 12:31 AM, devendra.aaru wrote:
> Hi wireless folks,
>
> in _rtl92c_store_pwrIndex_diffrate_offset (
> drivers/net/wireless/rtlwifi/rtl8192c/phy_common.c), there are lot of
> if conditions, checking the register address.
> my understanding is that if the register address matches to a
> particular rate, we set the txpower level to a particular group. but
> it is even possible with the switch or if else if statements,
>   please correct me if i am wrong.

Of course, that routine could be recoded using either a switch or if else 
statements. Unfortunately, I have more pressing matters to attend to. You can, 
however, submit a patch to change it and send it to the linux-wireless mailing 
list. You must follow the instructions in Documentation/SubmittingPatches, and 
the patch must apply using the wireless-testing git tree.

Larry

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html