lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 30 Jan 2012 16:45:49 +0000 From: Ben Hutchings <bhutchings@...arflare.com> To: Joe Perches <joe@...ches.com> CC: David Miller <davem@...emloft.net>, <netdev@...r.kernel.org>, <linux-net-drivers@...arflare.com> Subject: Re: [PATCH net-next 03/32] sfc: Remove parentheses around return expressions, reported by checkpatch On Fri, 2012-01-27 at 13:01 -0800, Joe Perches wrote: > On Fri, 2012-01-27 at 20:42 +0000, Ben Hutchings wrote: > > Fix the following error: > > ERROR: return is not a function, parentheses are not required > > Signed-off-by: Ben Hutchings <bhutchings@...arflare.com> > > trivia: > > > diff --git a/drivers/net/ethernet/sfc/rx.c b/drivers/net/ethernet/sfc/rx.c > [] > > @@ -98,8 +98,8 @@ static inline unsigned int efx_rx_buf_offset(struct efx_nic *efx, > > /* Offset is always within one page, so we don't need to consider > > * the page order. > > */ > > - return (((__force unsigned long) buf->dma_addr & (PAGE_SIZE - 1)) + > > - efx->type->rx_buffer_hash_size); > > + return ((__force unsigned long) buf->dma_addr & (PAGE_SIZE - 1)) + > > + efx->type->rx_buffer_hash_size; > > } > > The function returns unsigned int, perhaps the > cast should be (__force unsigned int) or the > function should return unsigned long or maybe > size_t? It's a page offset, so I believe unsigned int is correct. This function used to use the virtual address, and the compiler will warn about casting a pointer to an integer of smaller size. Now that it's using the DMA address, this no longer applies (and __force is not necessary either). Ben. -- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists