netdev - Re: [PATCH V2] net/sched: sch_plug - Queue traffic until an explicit release command

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <B99410E5-6E69-425A-913D-272058765A68@cs.ubc.ca>
Date:	Mon, 30 Jan 2012 08:47:45 -0800
From:	Shriram Rajagopalan <rshriram@...ubc.ca>
To:	Hagen Paul Pfeifer <hagen@...u.net>
Cc:	Jamal Hadi Salim <jhs@...atatu.com>,
	"<netdev@...r.kernel.org>" <netdev@...r.kernel.org>,
	Brendan Cully <brendan@...ubc.ca>
Subject: Re: [PATCH V2] net/sched: sch_plug - Queue traffic until an explicit release command

On 2012-01-30, at 6:54 AM, Hagen Paul Pfeifer <hagen@...u.net> wrote:

> 
> On Mon, 30 Jan 2012 09:45:56 -0500, Jamal Hadi Salim wrote:
> 
>> Please address the comment from Hagen on the printk (kill it).
>> Other than that i think this simple enough and non-intrusive
>> to other users that you can add an Acked-by from me.
>> It will be nice to get it to be generic as per Hagen's and my
>> earlier comments.
> 
> I thought about sch_plug a second time and I like the idea of a user-space
> based flow-controlled queue. But as I wrote in my first email: the current
> implementation is a little bit XEN specific. Make it more general
> (plug/unplug

The use case I cited in the kconfig was xen specific. 
The plug and unplug functionality is already there and is generic.

I can certainly rename the tcq #defs :)

> , plug/packet-based-unplug) and it is a great contribution.
> 

Could you elaborate a little on the packet-based-unplug ?

I got your earlier comment on "indefinite unplug" until an explicit
plug is received. Is that what you mean by packet-based-unplug ?


Shriram
> Hagen
> 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html