lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Mon, 30 Jan 2012 15:54:52 +0100
From:	Hagen Paul Pfeifer <hagen@...u.net>
To:	Jamal Hadi Salim <jhs@...atatu.com>
Cc:	Shriram Rajagopalan <rshriram@...ubc.ca>, <netdev@...r.kernel.org>,
	Brendan Cully <brendan@...ubc.ca>
Subject: Re: [PATCH V2] net/sched: sch_plug - Queue traffic until an explicit release command


On Mon, 30 Jan 2012 09:45:56 -0500, Jamal Hadi Salim wrote:

> Please address the comment from Hagen on the printk (kill it).
> Other than that i think this simple enough and non-intrusive
> to other users that you can add an Acked-by from me.
> It will be nice to get it to be generic as per Hagen's and my
> earlier comments.

I thought about sch_plug a second time and I like the idea of a user-space
based flow-controlled queue. But as I wrote in my first email: the current
implementation is a little bit XEN specific. Make it more general
(plug/unplug, plug/packet-based-unplug) and it is a great contribution.

Hagen

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists