netdev - Re: Sundance network driver (D-Link DFE-580TX) timeouts rendering interface unusable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1327935455.2297.5.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC>
Date:	Mon, 30 Jan 2012 15:57:35 +0100
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Ben Hutchings <ben@...adent.org.uk>
Cc:	Denis Kirjanov <kirjanov@...il.com>,
	"Mike ." <mike-bugreport@...mail.com>, 656476@...s.debian.org,
	netdev <netdev@...r.kernel.org>
Subject: Re: Sundance network driver (D-Link DFE-580TX) timeouts rendering
 interface unusable

Le lundi 30 janvier 2012 à 14:41 +0000, Ben Hutchings a écrit :
> On Mon, 2012-01-30 at 15:28 +0100, Eric Dumazet wrote:
> > Le lundi 30 janvier 2012 à 14:05 +0000, Ben Hutchings a écrit :
> > 
> > > Yes, I spotted that.  But no descriptors are pushed to the hardware
> > > here; that's done in the driver's TX tasklet.  Although... maybe that
> > > can run immediately when scheduled from here?  I've never had to deal
> > > with tasklets so I really don't know their semantics.
> > 
> > Thats probable on SMP ...
> 
> The bug report is for a UP system running a kernel built with
> SMP-alternatives.

Hmm, TX _completion_ is not run from tasklet but hardware IRQ, this is
why I added the spin_lock_irqsave().


Tasklet fires the TX, but hardware IRQ does the TX completion part.

This driver is ... interesting :)




--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html