lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 30 Jan 2012 17:10:36 +0000 From: Wei Liu <wei.liu2@...rix.com> To: Jan Beulich <JBeulich@...e.com> CC: <wei.liu2@...rix.com>, Ian Campbell <Ian.Campbell@...rix.com>, "xen-devel@...ts.xensource.com" <xen-devel@...ts.xensource.com>, "konrad.wilk@...cle.com" <konrad.wilk@...cle.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org> Subject: Re: [Xen-devel] [RFC PATCH V3 12/16] netback: multi-page ring support On Mon, 2012-01-30 at 16:35 +0000, Jan Beulich wrote: > >>> On 30.01.12 at 15:45, Wei Liu <wei.liu2@...rix.com> wrote: > > -int xenvif_map_frontend_rings(struct xenvif *vif, > > - grant_ref_t tx_ring_ref, > > - grant_ref_t rx_ring_ref) > > +int xenvif_map_frontend_rings(struct xen_comms *comms, > > + int domid, > > + unsigned long ring_ref[], > > + unsigned int ring_ref_count) > > { > > - void *addr; > > - struct xen_netif_tx_sring *txs; > > - struct xen_netif_rx_sring *rxs; > > - > > - int err = -ENOMEM; > > + struct gnttab_map_grant_ref op[NETBK_MAX_RING_PAGES]; > > + unsigned int i; > > + int err = 0; > > > > - err = xenbus_map_ring_valloc(xenvif_to_xenbus_device(vif), > > - tx_ring_ref, &addr); > > Any reason why you don't just extend this function (in a prerequisite > patch) rather than open coding a common utility function (twice) here, > so that other backends (blkback!) can benefit later as well. > > Jan > I'm mainly focusing on netback stuffs, so the code is slightly coupled with netback -- NETBK_MAX_RING_PAGES. To extend xenbus_map_ring_valloc and make more generic, it requires setting a global maximum page number limits on rings, I think it will require further investigation and code refactor -- which I have no time to attend to at the moment. :-/ Wei. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists