netdev - Re: brcm80211 breakage..

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120131195822.GA2175@polaris.bitmath.org>
Date:	Tue, 31 Jan 2012 20:58:22 +0100
From:	"Henrik Rydberg" <rydberg@...omail.se>
To:	"John W. Linville" <linville@...driver.com>
Cc:	Arend van Spriel <arend@...adcom.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	"Franky (Zhenhui) Lin" <frankyl@...adcom.com>,
	"John W. Linville" <linville@...hat.com>,
	Network Development <netdev@...r.kernel.org>,
	Rafał Miłecki <zajec5@...il.com>
Subject: Re: brcm80211 breakage..

> From 1f3587dd7cdb8e2a505c76041bd5b816e7bcfb67 Mon Sep 17 00:00:00 2001
> From: Henrik Rydberg <rydberg@...omail.se>
> Date: Tue, 31 Jan 2012 14:22:15 -0500
> Subject: [PATCH] bcma: don't fail for bad SPROM CRC
> 
> If it is OK ...?

How about this:

The brcmsmac driver is now using the bcma SPROM logic, which does not
recognize all chipsets that were functional prior to the switch. In
particular, the current code bails out on odd CRC errors in recent
Macbooks. This patch ignores those errors, with the argument that an
unrecognized SPROM should be treated similarly to a non-existing one.

> 
> Signed-off-by: John W. Linville <linville@...driver.com>
> ---
> Henrik, may I add a Signed-off-by line for you?

By all means, thanks.

>  drivers/bcma/main.c |    4 +---
>  1 files changed, 1 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/bcma/main.c b/drivers/bcma/main.c
> index febbc0a..ec31f7d 100644
> --- a/drivers/bcma/main.c
> +++ b/drivers/bcma/main.c
> @@ -169,10 +169,8 @@ int bcma_bus_register(struct bcma_bus *bus)
>  	err = bcma_sprom_get(bus);
>  	if (err == -ENOENT) {
>  		pr_err("No SPROM available\n");
> -	} else if (err) {
> +	} else if (err)
>  		pr_err("Failed to get SPROM: %d\n", err);
> -		return -ENOENT;
> -	}
>  
>  	/* Register found cores */
>  	bcma_register_cores(bus);
> -- 
> 1.7.4.4

Henrik
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html