netdev - Re: brcm80211 breakage..

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F284D34.9000602@broadcom.com>
Date:	Tue, 31 Jan 2012 21:21:08 +0100
From:	"Arend van Spriel" <arend@...adcom.com>
To:	"Henrik Rydberg" <rydberg@...omail.se>
cc:	"John W. Linville" <linville@...driver.com>,
	"Linus Torvalds" <torvalds@...ux-foundation.org>,
	"Franky (Zhenhui) Lin" <frankyl@...adcom.com>,
	"John W. Linville" <linville@...hat.com>,
	"Network Development" <netdev@...r.kernel.org>,
	"Rafał Miłecki" 
	<zajec5@...il.com>, "Hauke Mehrtens" <hauke@...ke-m.de>
Subject: Re: brcm80211 breakage..

On 01/31/2012 08:58 PM, Henrik Rydberg wrote:
>> From 1f3587dd7cdb8e2a505c76041bd5b816e7bcfb67 Mon Sep 17 00:00:00 2001
>> From: Henrik Rydberg <rydberg@...omail.se>
>> Date: Tue, 31 Jan 2012 14:22:15 -0500
>> Subject: [PATCH] bcma: don't fail for bad SPROM CRC
>>
>> If it is OK ...?
> 
> How about this:
> 
> The brcmsmac driver is now using the bcma SPROM logic, which does not
> recognize all chipsets that were functional prior to the switch. In
> particular, the current code bails out on odd CRC errors in recent
> Macbooks. This patch ignores those errors, with the argument that an
> unrecognized SPROM should be treated similarly to a non-existing one.
>

Not entirely correct. BCMA sprom logic is currently not used by
brcmsmac, but it sure (as hell) makes sense to do so. Currently, the
bcma SPROM logic is used in SoC chipsets (bcm47xx) and the b43 driver.

Gr. AvS

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html