netdev - Re: [PATCH iproute2] tc-sfq: update man page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1328023680.2297.27.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC>
Date:	Tue, 31 Jan 2012 16:28:00 +0100
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Jan Ceuleers <jan.ceuleers@...puter.org>
Cc:	Stephen Hemminger <shemminger@...tta.com>,
	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH iproute2] tc-sfq: update man page

Le mardi 31 janvier 2012 à 13:38 +0100, Jan Ceuleers a écrit :
> On 01/24/2012 02:29 PM, Eric Dumazet wrote:
> > Add documentation about RED mode, and new parameters (flows, depth)
> > added in linux 3.3
> >
> > Signed-off-by: Eric Dumazet<eric.dumazet@...il.com>
> > ---
> >   man/man8/tc-sfq.8 |  127 +++++++++++++++++++++++++++++++++++++-------
> >   1 file changed, 108 insertions(+), 19 deletions(-)
> >
> > diff --git a/man/man8/tc-sfq.8 b/man/man8/tc-sfq.8
> > index e177f56..5a651ff 100644
> > --- a/man/man8/tc-sfq.8
> > +++ b/man/man8/tc-sfq.8
> ...
> +Source and Destination port
> >   .P
> >   If these are available. SFQ knows about ipv4 and ipv6 and also UDP, TCP and ESP.
> >   Packets with other protocols are hashed based on the 32bits representation of their
> > -destination and the socket they belong to. A flow corresponds mostly to a TCP/IP
> > -connection.
> > +destination and source. A flow corresponds mostly to a TCP/IP connection.
> 
> Don't understand this. Did you want to replace "connection" by 
> "destination and source"? Do you mean that a "connection" is 
> characterised by source and destination?
> 
> 

Packets of other protocol (so not UDP, not TCP...) are hashed based on
their source IP _and_ destination IP

Old documentation wrongly stated the hash was done only based on
destination IP.

Also we no longer uses 'local socket' since SFQ uses standard rxhash or
flow dissector.



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html