netdev - Re: [PATCH net-next] tcp: md5: rcu conversion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1328024317.2297.31.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC>
Date:	Tue, 31 Jan 2012 16:38:37 +0100
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Shawn Lu <shawn.lu@...csson.com>
Cc:	"davem@...emloft.net" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"xiaoclu@...il.com" <xiaoclu@...il.com>
Subject: Re: [PATCH net-next] tcp: md5: rcu conversion

Le mardi 31 janvier 2012 à 16:18 +0100, Eric Dumazet a écrit :
> In order to be able to support proper RST messages for TCP MD5 flows, we
> need to allow access to MD5 keys without locking listener socket.
> 
> This conversion is a nice cleanup, and shrinks size of timewait sockets
> by 80 bytes.
> 
> IPv6 code reuses generic code found in IPv4 instead of duplicating it.
> 
> Control path uses GFP_KERNEL allocations instead of GFP_ATOMIC.
> 
> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>
> Cc: Shawn Lu <shawn.lu@...csson.com>

By the way, we probably need to add a limit on the number of keys a
socket can store. It seems previous code relied on kmalloc(big_array)
limits  (~4MB on x86) only.

sock_kmalloc() might be the right thing to use instead of kmalloc()



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html