lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Thu, 02 Feb 2012 14:20:05 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	jeffrey.t.kirsher@...el.com
Cc:	netdev@...r.kernel.org, gospo@...hat.com, sassmann@...hat.com
Subject: Re: [net 4/8] ixgbe: fix namespace issues when FCoE is not enabled

From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Date: Thu,  2 Feb 2012 04:20:17 -0800

> Several functions are made external but are not used externally when
> FCoE/DCB is not enabled.
> 
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> Tested-by: Phil Schmitt <phillip.j.schmitt@...el.com>

Do not crap up the *.c files with ifdefs like this.

Better to export these operations via an ops structure of
some kind, rather than doing stuff like this.

I'm not applying this series if it contains stuff like
this.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists