netdev - Re: [net 4/8] ixgbe: fix namespace issues when FCoE is not enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1328248014.2581.33.camel@jtkirshe-mobl>
Date:	Thu, 02 Feb 2012 21:46:54 -0800
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org, gospo@...hat.com, sassmann@...hat.com
Subject: Re: [net 4/8] ixgbe: fix namespace issues when FCoE is not enabled

On Thu, 2012-02-02 at 14:20 -0500, David Miller wrote:
> From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> Date: Thu,  2 Feb 2012 04:20:17 -0800
> 
> > Several functions are made external but are not used externally when
> > FCoE/DCB is not enabled.
> > 
> > Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> > Tested-by: Phil Schmitt <phillip.j.schmitt@...el.com>
> 
> Do not crap up the *.c files with ifdefs like this.
> 
> Better to export these operations via an ops structure of
> some kind, rather than doing stuff like this.
> 
> I'm not applying this series if it contains stuff like
> this.

I apologize Dave, that was my mistake.  I will drop this patch from the
series and find a better way to resolve the namespace errors.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)