netdev - Re: [PATCH] net: move ethtool include to where its used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120204.162331.1482938799603820869.davem@davemloft.net>
Date:	Sat, 04 Feb 2012 16:23:31 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	vapier@...too.org
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] net: move ethtool include to where its used

From: Mike Frysinger <vapier@...too.org>
Date: Fri,  3 Feb 2012 06:17:02 -0500

> The linux/mii.h headers has long been standalone for userspace.  But a
> recent commit added linux/ethtool.h to the include list even when it
> isn't used.  Since we only need this with __KERNEL__, move the include
> down to the right spot.  Now userland no longer needs to pull this in.
> 
> Signed-off-by: Mike Frysinger <vapier@...too.org>

I don't understand what the problem is.

linux/ethtool.h is a safely exported header file for userspace,
so if linux/mii.h now starts to include it this should make no
difference whatsoever for userspace unless userspace does something
bogus which in turn would mean it's almost certainly userspace
which is at fault here no the kernel headers.

You don't describe the exact nature of the failure nor have you shown
a specific actual failure, so we can only guess what the real problem
is.  And that's another thing that makes this patch submission bogus.

This change seems arbitrary and not necessary, therefore I am not
applying it.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html