netdev - Re: [PATCH] tcp_v4_send_reset: binding oif to iif in no sock case

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120204.162602.1922697409850241775.davem@davemloft.net>
Date:	Sat, 04 Feb 2012 16:26:02 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	shawn.lu@...csson.com
Cc:	eric.dumazet@...il.com, netdev@...r.kernel.org, xiaoclu@...il.com
Subject: Re: [PATCH] tcp_v4_send_reset: binding oif to iif in no sock case

From: Shawn Lu <shawn.lu@...csson.com>
Date: Sat, 4 Feb 2012 13:22:36 -0800

> +	/*
> +	 * When socket is gone, all binding information is lost.
> +	 * routing might fail in this case. using iif for oif to
> +	 * make sure we can deliver it
> +	 */

Comment is poorly formatted, and I'm getting tired of teaching
people

	/* That comments are formatted like
	 * this.
	 */

	/*
	 * Not like this.
	 */

or do you have infinite vertical lines on your monitor so that
this empty "/*" line has no impact on your screen real estate
like it does for the rest of us?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html