netdev - RE: [PATCH] tcp_v4_send_reset: binding oif to iif in no sock case

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <62162DF05402B341B3DB59932A1FA992B5B5C9FD00@EUSAACMS0702.eamcs.ericsson.se>
Date:	Sat, 4 Feb 2012 16:30:48 -0500
From:	Shawn Lu <shawn.lu@...csson.com>
To:	David Miller <davem@...emloft.net>
CC:	"eric.dumazet@...il.com" <eric.dumazet@...il.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"xiaoclu@...il.com" <xiaoclu@...il.com>
Subject: RE: [PATCH] tcp_v4_send_reset: binding oif to iif in no sock case

Sorry, will resubmit with right format. 

> -----Original Message-----
> From: David Miller [mailto:davem@...emloft.net] 
> Sent: Saturday, February 04, 2012 1:26 PM
> To: Shawn Lu
> Cc: eric.dumazet@...il.com; netdev@...r.kernel.org; xiaoclu@...il.com
> Subject: Re: [PATCH] tcp_v4_send_reset: binding oif to iif in 
> no sock case
> 
> From: Shawn Lu <shawn.lu@...csson.com>
> Date: Sat, 4 Feb 2012 13:22:36 -0800
> 
> > +	/*
> > +	 * When socket is gone, all binding information is lost.
> > +	 * routing might fail in this case. using iif for oif to
> > +	 * make sure we can deliver it
> > +	 */
> 
> Comment is poorly formatted, and I'm getting tired of teaching people
> 
> 	/* That comments are formatted like
> 	 * this.
> 	 */
> 
> 	/*
> 	 * Not like this.
> 	 */
> 
> or do you have infinite vertical lines on your monitor so 
> that this empty "/*" line has no impact on your screen real 
> estate like it does for the rest of us?
> --
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html