netdev - Re: [PATCH] net: fec: Remove macaddr option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120204.162936.1988486080455883986.davem@davemloft.net>
Date:	Sat, 04 Feb 2012 16:29:36 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	fabio.estevam@...escale.com
Cc:	netdev@...r.kernel.org, kernel@...gutronix.de,
	shawn.guo@...escale.com
Subject: Re: [PATCH] net: fec: Remove macaddr option

From: Fabio Estevam <fabio.estevam@...escale.com>
Date: Fri, 3 Feb 2012 15:25:04 -0200

> "macaddr" option allows users to pass the MAC address via kernel command line.
> 
> Feedbacks from Alan Cox and David Miller (http://www.spinics.net/lists/linux-usb/msg57821.html )
> mention that this is not a good idea, so remove it.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@...escale.com>

Whilst we can prevent new additions of such module options, you can't
just go and remove them from existing drivers without potentially
breaking things for people.

In this FEC case, the option was added more than a year ago.

I'm not applying this patch.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html