netdev - [PATCH] bcma: don't fail for bad SPROM CRC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Mon,  6 Feb 2012 14:26:41 +0100
From:	"Henrik Rydberg" <rydberg@...omail.se>
To:	"John W. Linville" <linville@...driver.com>
Cc:	netdev@...r.kernel.org, Henrik Rydberg <rydberg@...omail.se>,
	Arend van Spriel <arend@...adcom.com>,
	"Franky (Zhenhui) Lin" <frankyl@...adcom.com>,
	Rafał Miłecki <zajec5@...il.com>
Subject: [PATCH] bcma: don't fail for bad SPROM CRC

The brcmsmac driver is now checking the bcma SPROM CRCs, leaving some
chipsets unrecognized that were functional prior to the switch. In
particular, the current code bails out on recent Macbooks. This patch
simply ignores the outcome of the CRC check, with the argument that an
unrecognized SPROM should be treated similarly to a non-existing one.

Cc: Arend van Spriel <arend@...adcom.com>
Cc: Franky (Zhenhui) Lin <frankyl@...adcom.com>
Cc: Rafał Miłecki <zajec5@...il.com>
Signed-off-by: Henrik Rydberg <rydberg@...omail.se>
Signed-off-by: John W. Linville <linville@...driver.com>
---
Hi John,

It seems this patch may have gotten lost, at least I have not seen it
on any of the net/wireless parties. Arend, are you ok with the final
wording?

Thanks,
Henrik

 drivers/bcma/main.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/drivers/bcma/main.c b/drivers/bcma/main.c
index febbc0a..ec31f7d 100644
--- a/drivers/bcma/main.c
+++ b/drivers/bcma/main.c
@@ -169,10 +169,8 @@ int bcma_bus_register(struct bcma_bus *bus)
 	err = bcma_sprom_get(bus);
 	if (err == -ENOENT) {
 		pr_err("No SPROM available\n");
-	} else if (err) {
+	} else if (err)
 		pr_err("Failed to get SPROM: %d\n", err);
-		return -ENOENT;
-	}
 
 	/* Register found cores */
 	bcma_register_cores(bus);
-- 
1.7.9
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html