netdev - Re: [PATCH] bcma: don't fail for bad SPROM CRC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F2FD6D0.8070508@broadcom.com>
Date:	Mon, 6 Feb 2012 14:34:08 +0100
From:	"Arend van Spriel" <arend@...adcom.com>
To:	"Henrik Rydberg" <rydberg@...omail.se>
cc:	"John W. Linville" <linville@...driver.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"Franky (Zhenhui) Lin" <frankyl@...adcom.com>,
	"Rafał Miłecki" <zajec5@...il.com>
Subject: Re: [PATCH] bcma: don't fail for bad SPROM CRC

On 02/06/2012 02:26 PM, Henrik Rydberg wrote:
> The brcmsmac driver is now checking the bcma SPROM CRCs, leaving some
> chipsets unrecognized that were functional prior to the switch. In
> particular, the current code bails out on recent Macbooks. This patch
> simply ignores the outcome of the CRC check, with the argument that an
> unrecognized SPROM should be treated similarly to a non-existing one.

Suggestion:

The brcmsmac driver is now registered as a bcma device driver. Some
chipsets fail on SPROM CRC check in the bcma bus driver. This leaves the
chipset unrecognized and the bcma bus is not registered so that brcmsmac
is not probed. In particular, the current code .......

Gr. AvS




--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html