netdev - Re: [PATCH] fec: fix tx bounce handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1328545509.2220.70.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC>
Date:	Mon, 06 Feb 2012 17:25:09 +0100
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Tim Sander <tim.sander@....com>
Cc:	Hector Palacios <hector.palacios@...i.com>, netdev@...r.kernel.org,
	davem@...emloft.net, shawn.guo@...aro.org, jgq516@...il.com,
	rostedt@...dmis.org, u.kleine-koenig@...gutronix.de,
	tglx@...utronix.de, Zeng Zhaoming <b32542@...escale.com>,
	Frank Li <Frank.Li@...escale.com>
Subject: Re: [PATCH] fec: fix tx bounce handling

Le lundi 06 février 2012 à 17:09 +0100, Tim Sander a écrit :
> Hi
> 
> I forward ported the patch i have for 3.0-rt (which was working on a quick test) 
> to the net-dev  branch with the patch from Eric mixed in. 
> 
> But a quick test revealed that dmesg is full of:
> eth0: tx queue full!.
> Not good! Any suggestions on this?
> 

Please dont mix things.

My patch has nothing to do with the TX ring handling.

> Tim
> 
> Heres my patch for 3.3:
> 
> diff --git a/drivers/net/ethernet/freescale/fec.c b/drivers/net/ethernet/freescale/fec.c
> index 336edd7..74d5865 100644
> --- a/drivers/net/ethernet/freescale/fec.c
> +++ b/drivers/net/ethernet/freescale/fec.c
> @@ -284,11 +284,6 @@ fec_enet_start_xmit(struct sk_buff *skb, struct net_device *ndev)
>         unsigned short  status;
>         unsigned long flags;
>  
> -       if (!fep->link) {



We first must fix the driver before removing this work around.


> -               /* Link is down or autonegotiation is in progress. */
> -               return NETDEV_TX_BUSY;
> -       }
> -

In fact, returning NETDEV_TX_BUSY here is proof driver is buggy.

We should not enter fec_enet_start_xmit() is device is not ready to send
frames.

There are missing netif_stop_queue(dev) in this driver.



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html