netdev - Re: [PATCH 0/4] Fix routing metrics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120208.151837.75403230557283008.davem@davemloft.net>
Date:	Wed, 08 Feb 2012 15:18:37 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	steffen.klassert@...unet.com
Cc:	timo.teras@....fi, netdev@...r.kernel.org
Subject: Re: [PATCH 0/4] Fix routing metrics

From: Steffen Klassert <steffen.klassert@...unet.com>
Date: Wed, 8 Feb 2012 08:30:37 +0100

> On Mon, Feb 06, 2012 at 03:29:16PM -0500, David Miller wrote:
>> 
>> Thinking about this, it seems overkill to check this on every metric
>> access.
>> 
>> You have an opportunity to validate metrics when the peer is bound to
>> the route.
>> 
>> This is because any change to the FIB metrics, is in turn a change
>> to the FIB, which therefore invalidates the entire routing cache.
>> 
>> So you can be sure that a new route cache entry will be created, and
>> at that creation time you can ensure that we'll respect the updated
>> FIB metrics if encessary.
> 
> Not sure if I get you right here, but that's what this patchset
> does. It invalidates the metrics on the peer by incrementing
> peer_genid in rt_cache_invalidate() which is invoked on every FIB
> change. Then, on slowpath route lookup it checks in rt_init_metrics()
> whether the peer_genid changed. If it changed, it exchanges the
> invalidated merics with new ones and copies the informations from
> the FIB into it.

If the routing cache is invalided, you'll "see" this updated inetpeer
because every single routing cache entry will get rebuilt.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html